Fix templating LicenseFieldValue on license sync #4468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgalsaleh
commented
Feb 23, 2024
| } | ||
|
|
||
| func RenderDir(archiveDir string, a *apptypes.App, downstreams []downstreamtypes.Downstream, registrySettings registrytypes.RegistrySettings, sequence int64) error { | ||
| kotsKinds, err := kotsutil.LoadKotsKinds(archiveDir) | ||
| func RenderDir(opts types.RenderDirOptions) error { |
There was a problem hiding this comment.
the beginning of this function where loading the installation, license, and config values from the upstream directory rather than the kotsKinds directory when creating a new version is what addresses the regression.
cbodonnell
approved these changes
Feb 23, 2024
sgalsaleh
deleted the
salah/sc-99587/template-licensefieldvalue-is-broken
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes SC99587
Special notes for your reviewer:
Steps to reproduce
Does this PR introduce a user-facing change?
Does this PR require documentation?
NONE